Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T/224: [Lint] getGitIgnore() should transform directories as the glob patterns for Gulp #225

Merged
merged 3 commits into from
Jun 15, 2017

Conversation

pomek
Copy link
Member

@pomek pomek commented Jun 5, 2017

Suggested merge commit message (convention)

Feature: getGitIgnore() will transform directories to glob patterns. Closes #224.

Required in order to use a more standard "directory/" notation in .gitignore.

@Reinmar
Copy link
Member

Reinmar commented Jun 14, 2017

What we should check on this occasion is whether we really need dev-lint package.

Let's say that ESLint can check .gitignore itself (a reasonable assumption, I think) and that it also accepts some other patterns (we need to ignore the src/lib/ directory). This would mean that everything the dev-lint package does could be easily replaced with ESLint, rendering this package unnecessary.

Let's think about this because I'd gladly remove this package and moved the linting script to package's gulpfiles.

PS. I forgot about getting pre-commit files. I don't think that ESLint can do that out of the box. So... ignore my comment :D

@Reinmar
Copy link
Member

Reinmar commented Jun 14, 2017

There's lint-staged https://medium.com/@okonetchnikov/make-linting-great-again-f3890e1ad6b8 and I quite like this:

// package.json
...
"scripts" {
 "lint-staged": "lint-staged",
 "stylelint-staged": "stylelint --syntax scss"
},
"lint-staged": {
 "*.js": "eslint",
 "*.scss": "stylelint-staged"
},
"pre-commit": "lint-staged"
...

This would let us remove the gulp depdendency from all small packages and gulpfile.js and dev-lint of course.

This is an interesting direction... I'll report a separate ticket for it because it's a bigger topic of course.

@Reinmar Reinmar merged commit fbe6127 into master Jun 15, 2017
@Reinmar Reinmar deleted the t/224 branch June 15, 2017 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants